JST-112: Drop imports using .js extensions and… #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
commented
Jul 27, 2023
|
I was debugging the issue with import {add} from "./check";
describe("Example test", () => {
test("a+b", () => {
expect(add(1, 2)).toEqual(3);
})
});While in case of ts-mocha, that |
grisha87
force-pushed
the
feature/JST-112/drop-js-extensions-from-inport
branch
from
06ccc19
to
f2306ef
Compare
grisha87
commented
Aug 2, 2023
…roduce separate artifacts for browser and nodejs runtimes - Removing .js extensions from imports in tests - Removing more .js extensions... - Ported unit tests from mocha/chai to jest - Attempt to bring Goth tests back to life - Change way of importing child_process to fix an issue with rollup and polyfil - Added missing jest related packages - Increase allowed timeout for Goth to 180s - Skipped one test, scheduled for research - Removing newly added .js extensions - Added TS-ignore for the lines which are affected by ts-node issue - Updated integration tests to check with goth on GitHub Actions - Fixed type issue in one of the tests and removed redundant await
… against goerli testnet on local machines - Test formatting (fixup) - Moved the ws-browser test to the test directory as it was causing issues with rollup - Test formatting (fixup) - Fixing the test which came from master branch (fixup) - Fixing the test which came from master branch (fixup) - Report gftp startup errors - Enable manual trigger for the goth workflow - Add debugging information to troubleshoot CI - Fixed task.spec.file and added runInBand to goth tests - Add debugging information to troubleshoot CI - Fixed spawning gftp by shell - Wait for GFTP to start properly before interacting with it - Fix-up - Logging update - Start and stop Goth via global setup - Adjusted timeouts - Timeout data type patch - Fixed logging in tests, added global startup timeut and brought batck import.meta.url - Dealing with remaining integration test failures - Added missing import - Force exit integration tests
grisha87
force-pushed
the
feature/JST-112/drop-js-extensions-from-inport
branch
from
c1022f3
to
4bc6167
Compare
- mocha - chai - quibble - ts-mocha - chai-uuid - chai-spies - chai-as-promised - @types/mocha - @istanbuljs/nyc-config-typescript - nyc
mgordel
approved these changes
Aug 4, 2023
| /examples/adv-web-example/.nuxt |
| "test": "npm run test:unit && npm run test:integration", | ||
| "test:unit": "jest --config tests/unit/jest.config.json", | ||
| "test:integration": "jest --config tests/integration/jest.config.json tests/integration/**.spec.ts --runInBand --forceExit", | ||
| "test:integration:no-goth": "jest tests/integration/**.spec.ts --testTimeout=180000 --runInBand --forceExit", |
There was a problem hiding this comment.
timeout is defined in test/integration/jest.config.json so probably not needed here..
yajsapi/package/repo_resolver.ts
Outdated
There was a problem hiding this comment.
This file is to be deleted, no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust rollup config to produce separate artifacts for browser and nodejs runtimes