Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for filtering provider offers by golem.inf.cpu.threads and golem.inf.cpu.cores #231

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

filipgolem
Copy link
Contributor

No description provided.

@filipgolem filipgolem self-assigned this Jun 30, 2021
@filipgolem filipgolem marked this pull request as ready for review June 30, 2021 15:19
@filipgolem filipgolem requested a review from azawlocki July 1, 2021 08:55
@shadeofblue shadeofblue self-requested a review July 1, 2021 08:56
yajsapi/package/index.ts Outdated Show resolved Hide resolved
@filipgolem filipgolem requested a review from azawlocki July 2, 2021 09:25
}: RepoOpts): Promise<Package> {
/*
Builds reference to a demand decorator.

- *image_hash*: finds package by its contents hash.
- *min_mem_gib*: minimal memory required to execute application code.
- *min_storage_gib* minimal disk storage to execute tasks.
- *min_cpu_threads*: minimal available logical CPU cores (CPU threads).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- *min_cpu_threads*: minimal available logical CPU cores (CPU threads).
- *min_cpu_threads*: minimal number of available logical CPU cores (CPU threads).

Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipgolem filipgolem merged commit 55e61f4 into master Jul 2, 2021
@filipgolem filipgolem deleted the cpu-cores-constraints branch July 2, 2021 09:58
filipgolem added a commit that referenced this pull request Jul 2, 2021
filipgolem added a commit that referenced this pull request Jul 2, 2021
* Support for filtering provider offers by golem.inf.cpu.threads and golem.inf.cpu.cores (#231)
* Send valid termination reason (#229)
* Reduce log entries related to confirmed proposals (#230)
filipgolem added a commit that referenced this pull request Aug 5, 2021
* Support for filtering provider offers by golem.inf.cpu.threads and golem.inf.cpu.cores #231
* Use commandIndex parameter in getExecBatchResults #239
* Make engine params configurable via env variables #241
* Reduce log entries related to confirmed proposals #230
* Use event consumer cancellation token to properly stop event consumer #248
* Send valid termination reason #229
* Use ya-ts-client 0.5.1 #238
* Yacat integration test: use library source code instead of installed package
prekucki pushed a commit that referenced this pull request Jul 11, 2022
prekucki pushed a commit that referenced this pull request Jul 11, 2022
* Support for filtering provider offers by golem.inf.cpu.threads and golem.inf.cpu.cores (#231)
* Send valid termination reason (#229)
* Reduce log entries related to confirmed proposals (#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants