Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent find_offers() #187

Merged
merged 9 commits into from
May 25, 2021
Merged

Concurrent find_offers() #187

merged 9 commits into from
May 25, 2021

Conversation

filipgolem
Copy link
Contributor

@filipgolem filipgolem commented May 17, 2021 •
edited
Loading

No description provided.

@filipgolem filipgolem requested a review from azawlocki May 17, 2021 13:58
@filipgolem filipgolem changed the title Concurrent find offers Concurrent find_offers() May 17, 2021
@filipgolem filipgolem marked this pull request as draft May 17, 2021 14:02
@filipgolem filipgolem self-assigned this May 18, 2021
@filipgolem filipgolem linked an issue May 18, 2021 that may be closed by this pull request
Port "Make find_offers() an Executor method; handle offer proposals concurrently" from yapapi #164
Closed
@filipgolem filipgolem marked this pull request as ready for review May 18, 2021 08:41
filipgolem
filipgolem commented May 21, 2021
View reviewed changes
yajsapi/executor/index.ts Outdated Show resolved Hide resolved
azawlocki
azawlocki approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipgolem filipgolem merged commit bdada62 into master May 25, 2021
@filipgolem filipgolem deleted the improve-find-offers branch May 25, 2021 08:58
prekucki pushed a commit that referenced this pull request Jul 11, 2022
@filipgolem
Concurrent find_offers() (#187)
fe474e0 
* Concurrent find_offers
* Use SubmissionState in find_offers
* Make find_offers() an Executor method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

Assignees

@filipgolem filipgolem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port "Make find_offers() an Executor method; handle offer proposals concurrently" from yapapi
2 participants
@filipgolem @azawlocki