Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource-rental): fixed error handling when creating an exe-unit #1028

Merged
merged 3 commits into from
Jul 15, 2024
Merged

fix(resource-rental): fixed error handling when creating an exe-unit #1028

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70fa746
fix(resource-rental): fixed error handling when creating an exe-unit
mgordel Jul 11, 2024
6ac6f8e
refactor: moved logging and event emitting to first catch block
mgordel Jul 11, 2024
cb16e9d
refactor: added debug logging to error handling
mgordel Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/resource-rental/resource-rental.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ export class ResourceRental {
) {
this.networkNode = this.resourceRentalOptions?.networkNode;

this.createExeUnit(this.abortController.signal);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the explanation which you provided on the PR. Still, I'd recommend gracefully logging the error on debug level for the sake of troubleshooting in future.

this.createExeUnit(this.abortController.signal).catch((error) =>
this.logger.debug(`Failed to automatically create the exe unit during resource rental initialization`, { error }),
);
// TODO: Listen to agreement events to know when it goes down due to provider closing it!
}

Expand Down