feat: added missing events in the resource rental module #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
suggested changes
Jun 28, 2024
| exeUnitDestroyed: (activity: Activity) => void; | ||
|
|
||
| /** Emitted when there is an error while destroying the ExeUnit */ | ||
| errorDestroyingExeUnit: (error: Error) => void; |
There was a problem hiding this comment.
Would just keep this as error and then leave the details of what happened to the error itself.
There was a problem hiding this comment.
ok, in this case it may look better, I suggested other modules where we have it distinguished in this way and I wanted to keep consistency
| exeUnitCreated: (activity: Activity) => void; | ||
|
|
||
| /** Emitted when there is an error while creating the ExeUnit */ | ||
| errorCreatingExeUnit: (error: Error) => void; |
There was a problem hiding this comment.
Would just keep this as error and then leave the details of what happened to the error itself.
grisha87
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.