Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace readable with observables #1002

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

SewerynKras
Copy link
Contributor

Breaking changes:

  • executor.execute is no longer an async function that sends the script and creates a Readable. Instead, it synchronously creates an observable that once subscribed to, sends the script and starts emitting it's results
  • RemoteProcess (result of runAndStream) now uses Subjects instead of Readables to implement stdout and stderr
  • Removed stream polyfill as it's no longer used

@SewerynKras SewerynKras requested review from grisha87 and mgordel June 27, 2024 16:27
src/activity/exe-unit/batch.ts Outdated Show resolved Hide resolved
src/activity/exe-unit/exe-unit.ts Outdated Show resolved Hide resolved
src/shared/utils/rxjs.ts Show resolved Hide resolved
src/activity/exe-script-executor.ts Show resolved Hide resolved
src/activity/exe-script-executor.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@grisha87 grisha87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per remarks in the comments :)

@SewerynKras SewerynKras merged commit 13e4550 into beta Jul 1, 2024
8 checks passed
@SewerynKras SewerynKras deleted the feature/JST-989/replace-readable-with-observables branch July 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants