-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAP-14] Network Insights API #37
base: master
Are you sure you want to change the base?
Conversation
aa5b4c9
to
03d65a7
Compare
03d65a7
to
dbf253e
Compare
OK, I see the purpose of this design. Immediate thoughts:
|
I'm not saying "indices" is the prettiest and smoothest name, but I still prefer "index" to "rate"/"rating"/"grade". IOW, "Rating API"/"Grading API" are for me a special case of "node indices API", but there are also cases that are not rating/grading. (I don't have a very strong opinion here, I'd be glad to discuss this) |
Most of the content is already there - there are few gaps to be filled and also some careful rereading & editing is required.
TODOs filled. Rereading still needed.
Also: this GAP is only about read-only access to some data, there's nothing like "save node rating" here. |
5af3a18
to
36ca76a
Compare
Co-authored-by: stranger80 <[email protected]>
Maybe could be |
TC Session 27/01/2022:
|
Node Data API? |
abbae05
to
eafa543
Compare
There are already few examples of node indices APIs that are in progress or planned: | ||
|
||
* [Benchmark-based provider reputation (GAP-10)](https://github.com/golemfactory/golem-architecture/pull/33) | ||
* [Golem Stats](https://stats.golem.network). This API is currently used e.g. by the [community-created provider agent](https://gist.github.com/sv3t0sl4v/28f896752edc9e20347ffc6d8cefe74c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think golem stats is a bad example of this GAP because it uses metric data private to golem factory, making is heavily centralised.
TC 10.02.2022:
|
5233f68
to
fefdb09
Compare
In commit fefdb09 I've mentioned following discussion points:
(I'm not sure though if I've done it the way you intended). |
Change the name of the API to "Network Insights API". |
To be approved @ TC 2022-03-10 |
No description provided.