[GAP-4] Computation Manifest #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranciszkiewicz
force-pushed
the
mf/GAP/comp-manifest
branch
from
48021f5 to
322b982
Compare
stranger80
changed the title
stranger80
reviewed
Oct 31, 2021
stranger80
reviewed
Oct 31, 2021
stranger80
reviewed
Oct 31, 2021
stranger80
reviewed
Oct 31, 2021
stranger80
reviewed
Oct 31, 2021
stranger80
reviewed
Oct 31, 2021
Co-authored-by: stranger80 <[email protected]>
shadeofblue
reviewed
Nov 3, 2021
shadeofblue
reviewed
Nov 3, 2021
shadeofblue
reviewed
Nov 3, 2021
stranger80
reviewed
Nov 3, 2021
Co-authored-by: shadeofblue <[email protected]>
johny-b
reviewed
Nov 17, 2021
|
Summary of TC review: once the remark from JBetley is addressed we consider this GAP as "signed off" |
Comment on lines
+108
to
+111
| - `["{\"run\": { \"value\": \"/bin/date -R\", \"env\": { \"VAR\": \"42\" } }"]` | ||
| - `["{\"run\": { \"value\": \"/bin/date\", \"env\": { \"VAR\": \"4[0-9]+\" }, \"match\": \"regex\"}"]` | ||
| - `["{\"run\": { \"value\": \"/bin/date -R\", \"env\": { \"VAR\": { \"value\": \"4[0-9]+\", \"match\": \"regex\" } }"]` | ||
| - `["{\"run\": { \"value\": \"/bin/[a-zA-Z0-9]*\", \"match\": \"regex\" }"]` |
There was a problem hiding this comment.
value or args??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.