Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe GSB #120

Merged
merged 1 commit into from
Nov 5, 2024
Merged

docs: describe GSB #120

merged 1 commit into from
Nov 5, 2024

Conversation

dopiera
Copy link
Collaborator

@dopiera dopiera commented Nov 3, 2024

This change is Reviewable

Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dopiera)


arch-snapshot/arch.md line 569 at r1 (raw file):

like [Windows
DCOM](https://en.wikipedia.org/wiki/Distributed_Component_Object_Model),
[CORBA](https://en.wikipedia.org/wiki/CORBA), and

Those links are good as an intuition at most when someone knows those technologies. But as a replacement for description they are rather poor, because they talk about completely different things :(

But let's leave this, because we are short on time anyway


arch-snapshot/arch.md line 582 at r1 (raw file):

  by paths composed of segments separated by a '/' sign. Components are
  responsible not just for a single path but for all paths that share a
  certain prefix. This design allows the path itself to carry additional

This is not true, at most it is only naming convention. In general you bind to GSB handlers to specific message on specific path. You are allowed to bind on prefix, but it is rather exception then rule, used only in net. And in this case you get untyped messages.

You are allowed to bind on any path even on prefix that by convention belongs to certain module.

Suggestion:

  Components are responsible not just for a single path but for all paths that share a
  certain prefix. This design allows the path itself to carry additional

arch-snapshot/arch.md line 588 at r1 (raw file):

* **Absence of remote service concepts**: GSB does not distinguish between
  local and remote services. Instead, a dedicated component, called **Net**,

Maybe link to specific chapter?


arch-snapshot/arch.md line 591 at r1 (raw file):

  is responsible for forwarding traffic to remote targets. The target’s
  address is specified within the path, and the Net component uses this
  address to direct the payload to the appropriate remote destination. It then

Maybe link to chapter about GSB prefix translation

Copy link
Collaborator Author

@dopiera dopiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @nieznanysprawiciel)


arch-snapshot/arch.md line 569 at r1 (raw file):

Previously, nieznanysprawiciel wrote…

Those links are good as an intuition at most when someone knows those technologies. But as a replacement for description they are rather poor, because they talk about completely different things :(

But let's leave this, because we are short on time anyway

Added some quick explanation.


arch-snapshot/arch.md line 582 at r1 (raw file):

Previously, nieznanysprawiciel wrote…

This is not true, at most it is only naming convention. In general you bind to GSB handlers to specific message on specific path. You are allowed to bind on prefix, but it is rather exception then rule, used only in net. And in this case you get untyped messages.

You are allowed to bind on any path even on prefix that by convention belongs to certain module.

Done.


arch-snapshot/arch.md line 588 at r1 (raw file):

Previously, nieznanysprawiciel wrote…

Maybe link to specific chapter?

Done.


arch-snapshot/arch.md line 591 at r1 (raw file):

Previously, nieznanysprawiciel wrote…

Maybe link to chapter about GSB prefix translation

Done.

Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dopiera)


arch-snapshot/arch.md line 582 at r1 (raw file):

Previously, dopiera (Marek Dopiera) wrote…

Done.

hmmm, I have concerns, but let's leave it

@nieznanysprawiciel nieznanysprawiciel merged commit 89f6c22 into new-arch Nov 5, 2024
@nieznanysprawiciel nieznanysprawiciel deleted the md/gsb branch November 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants