Set status to Settled after task is closed, not before

golemfactory · Jul 26, 2024 · cc30a60 · cc30a60
1 parent 87de05e
commit cc30a60
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Golem/Job.cs b/Golem/Job.cs
@@ -117,6 +117,7 @@ public bool Active
             }
         }
 
+        public bool IsClosed { get => !Active; }
 
         public void UpdateActivityState(ActivityStatePair activityState)
         {
@@ -214,7 +215,7 @@ public static JobStatus ResolveTerminationReason(string? code)
             Logger.LogInformation($"Job: {this.Id}, confirmed sum: {confirmedSum}, job expected reward: {this.CurrentReward}");
 
             // Workaround for yagna unable to change status to SETTLED when using partial payments
-            if (this.CurrentReward == confirmedSum)
+            if (this.IsClosed && this.CurrentReward == confirmedSum)
             {
                 return IntoPaymentStatus(InvoiceStatus.SETTLED);
             }