Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Replace pyelliptic #1217

Closed
mfranciszkiewicz opened this issue Jul 7, 2017 · 6 comments
Closed

Replace pyelliptic #1217

mfranciszkiewicz opened this issue Jul 7, 2017 · 6 comments

Comments

@mfranciszkiewicz
Copy link
Contributor

We should look for a replacement forpyelliptic since it is no longer maintained.

Proposed replacement: https://github.com/pyca/cryptography
@Wolf480pl
Copy link
Contributor

Wolf480pl commented Sep 12, 2017 •
edited
Loading

AFAIK this issue reduces to ethereum/pydevp2p#58 cause I don't see pyelliptic used anywhere in golem code.

@Wolf480pl
Copy link
Contributor

cryptography doesn't call (or provide a way to call) OpenSSL's check_key :(

etam added a commit that referenced this issue Dec 6, 2017
@etam
use pyelliptic compatible with openssl 1.1
4ffde37 
pyelliptic is officially deprecated
yann2192/pyelliptic#50 and we want to
replace it (#1217). Until then, a patched version is required.
@etam etam mentioned this issue Dec 6, 2017
Closed
@mfranciszkiewicz
Copy link
Contributor Author

Initial 1.1-compatible version of pyelliptic: https://github.com/mfranciszkiewicz/pyelliptic

@maaktweluit
Copy link
Contributor

Yay! maybe we can also resolve some of the loading / path hacks at the top of https://github.com/golemfactory/golem-messages/blob/master/golem_messages/cryptography.py

@mfranciszkiewicz mfranciszkiewicz mentioned this issue Jan 25, 2018
Closed
@badb
Copy link
Contributor

badb commented Feb 23, 2018

@mfranciszkiewicz Can we close this issue?

@mfranciszkiewicz
Copy link
Contributor Author

@badb I believe so. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@badb @Wolf480pl @mfranciszkiewicz @maaktweluit