Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand comprehensive test with err #996

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Expand comprehensive test with err #996

merged 1 commit into from
Oct 8, 2024

Conversation

afsalthaj
Copy link
Contributor

@afsalthaj afsalthaj commented Oct 8, 2024

A small follow up PR on 1b0902a

  • Custom message for assertion with textual representation of type annotated value to make debugging easier
  • Expand the comprehensive test with err pattern match. No bugs captured with this expansion but its important to cover as much as possible. We will be continuing to do this.
  • Remove unwrap from or helper constructor. It looks like this constructor was never used.

@afsalthaj afsalthaj changed the title Expand tests that return errors Expand comprehensive test with err Oct 8, 2024
@afsalthaj afsalthaj merged commit 648cfce into main Oct 8, 2024
17 checks passed
@afsalthaj afsalthaj deleted the expand_more branch October 8, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants