worker bridge - idempotency key #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsalthaj
approved these changes
May 8, 2024
|
Currently you can set it using Rig any way you want (for example by forwarding that or any other header) but it's not happening automatically |
|
Setting the idempotency key is per binding, and this part was already done in @vigoo 's big PR |
vigoo
reviewed
May 12, 2024
| } else { | ||
| resolved_route | ||
| .headers | ||
| .get("idempotency-key") |
There was a problem hiding this comment.
Is this working case-insensitively?
There was a problem hiding this comment.
headers should not be case sensitive, i added test
vigoo
approved these changes
May 12, 2024
justcoon
force-pushed
the
worker_idempotency_key
branch
from
78f94d2 to
ccd5405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.