Update related oplog entries and removing VersionedWorkerId #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justcoon
reviewed
Apr 17, 2024
| @@ -47,7 +46,7 @@ message LaunchNewWorkerRequest { | |||
|
|
|||
| message LaunchNewWorkerResponse { | |||
| oneof result { | |||
| golem.worker.VersionedWorkerId success = 1; | |||
| golem.worker.WorkerId success = 1; | |||
There was a problem hiding this comment.
actually i think it is quiet useful, if this returning version of created worker, maybe instead there should be
message LaunchNewWorkerSuccess {
golem.worker.WorkerId worker_id = 1;
uint64 template_version = 2;
...
}
message LaunchNewWorkerResponse {
oneof result {
LaunchNewWorkerSuccess success = 1;
...
}
}also in such way it is more prepared for future extensions of response
justcoon
reviewed
Apr 17, 2024
| @@ -47,7 +30,7 @@ impl WorkerApi { | |||
| &self, | |||
| template_id: Path<TemplateId>, | |||
| request: Json<WorkerCreationRequest>, | |||
| ) -> Result<Json<VersionedWorkerId>> { | |||
| ) -> Result<Json<WorkerId>> { | |||
There was a problem hiding this comment.
similar like i mentioned in case of gRpc api
instead of just WorkerId, have some payload
struct WorkerCreationResponse {
worker_id: WorkerId,
template_version: u64
}
justcoon
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #387
Also removes the concept of a
VersionedWorkerIdas it is confusing (there cannot be different versions of the same worker identified by aWorkerId) and used inconsistently.