Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement worker fork #1209

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Implement worker fork #1209

wants to merge 11 commits into from

Conversation

afsalthaj
Copy link
Contributor

No description provided.

@afsalthaj afsalthaj changed the title Implement fork Implement worker fork Dec 24, 2024
@vigoo vigoo linked an issue Dec 27, 2024 that may be closed by this pull request
@vigoo
Copy link
Contributor

vigoo commented Dec 27, 2024

I will do a proper review later, but some initial mismatch from the ticket:

  • The forking logic should not be implemented in the gRPC request handlers. That should just be a thin layer as we want to have the actual forking logic used later in the debugging service for example. So as I wrote in the ticket, find a place (one of the "service layers" or create a new one) for it and from the gRPC request handler just call it.
  • The ticket explicitly asks for opening the worker in suspended mode and use the Oplog instance of it to read the source oplog - and not the "global" one in OplogService. I am not sure exactly why did I ask for that but I suspect there was a reason :) By using Oplog it is properly synchronized in case the worker is running etc. So let's just do it in the way as the ticket asks.

@afsalthaj
Copy link
Contributor Author

I used get_or_create_suspended and used oplog from there. If you look at some previous commits you can see that to later change to this one - but I thought it's the same. Anyway I will revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial worker forking
2 participants