Test stability improvements #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vigoo
commented
Dec 3, 2024
vigoo
commented
- Less sleep ⏰
- Timeouts/flakyness settings for sharding tests
- Larger timeout for dynamic large memory allocation test
- Removed hardcoded file sizes from tests
mschuwalow
reviewed
Dec 3, 2024
| let mut events = vec![]; | ||
| rx.recv_many(&mut events, 100).await; | ||
| let start_time = Instant::now(); | ||
| while events.len() < 2 && start_time.elapsed() < Duration::from_secs(5) { |
There was a problem hiding this comment.
I think we can rely on test timeouts to limit the polling instead of inlining it into the tests
There was a problem hiding this comment.
Thinking more about it, it's harder to come up with a good timeout on the whole test, because things like the compilation time of the WASM are hard to predict (how slow it is on CI).
Saying "after the invocation is done, we wait at most 5 seconds for the async log fetching to return some things" feels easier to work with to me.
mschuwalow
reviewed
Dec 3, 2024
|
|
||
| let (status1, _) = executor.get_worker_metadata(&worker_id).await.unwrap(); | ||
| executor | ||
| .wait_for_status(&worker_id, WorkerStatus::Running, Duration::from_secs(5)) |
There was a problem hiding this comment.
Same here, I would propose to just poll forever for the expected status and move operational matters such as timeouts fully into test framework configuration.
mschuwalow
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.