Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Enum and Variant types to be part of type_registry #966

Closed
afsalthaj opened this issue Sep 24, 2024 · 0 comments · Fixed by #987
Closed

Avoid Enum and Variant types to be part of type_registry #966

afsalthaj opened this issue Sep 24, 2024 · 0 comments · Fixed by #987
Assignees
Labels
Milestone

Comments

@afsalthaj
Copy link
Contributor

There isn't a need to have those types in the type_registry, that everything can be considered as a function indeed.
Somewhere I added to branch out specific logic, and after making significant changes later on with Rib, I can't see the value-add in it.

@afsalthaj afsalthaj self-assigned this Sep 24, 2024
@afsalthaj afsalthaj added the rib label Sep 24, 2024
@vigoo vigoo added this to the Golem 1.1 milestone Sep 30, 2024
afsalthaj added a commit that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants