Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests #6

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Add initial tests #6

merged 7 commits into from
Aug 21, 2024

Conversation

danieletorelli
Copy link
Contributor

This is a preliminary work that aims to set foundations to new features and changes, providing a base set of unit tests.
I also bumped dependencies here and there and cleaned up the deprecated toolchain action in CI.

The unit tests have some parts disabled because (still) unsupported in codegen.

@danieletorelli
Copy link
Contributor Author

I also added the job that compiles the output files with scalac. Please find a sample run in my fork: https://github.com/danieletorelli/golem-scalajs-wit-bindgen/actions/runs/10485208393

@vigoo
Copy link
Collaborator

vigoo commented Aug 21, 2024

Nice!

Some notes:

  • stream and future are coming with wasi preview3 and we are not supporting it for a while so those are not important
  • use and import, and resource support (fully, with constructors, methods and static methods and proper dropping) are very important to do anything useful (http, rpc etc)

@danieletorelli
Copy link
Contributor Author

Nice!

Some notes:

  • stream and future are coming with wasi preview3 and we are not supporting it for a while so those are not important
  • use and import, and resource support (fully, with constructors, methods and static methods and proper dropping) are very important to do anything useful (http, rpc etc)

Thank you, I look forward to a discussion where we could design a way to efficiently provide support for use and import constructs in Scala/Scalajs. For now indeed those parts are commented out in the tests but I see indeed that they are fundamental to make anything meaningful.

@vigoo vigoo merged commit 9f4ba4c into golemcloud:master Aug 21, 2024
4 checks passed
@danieletorelli danieletorelli deleted the initial-tests branch August 21, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants