Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use firebase-json to load rules #111

Merged
merged 1 commit into from
Jan 4, 2017
Merged

feat: use firebase-json to load rules #111

merged 1 commit into from
Jan 4, 2017

Conversation

dinoboff
Copy link
Collaborator

@dinoboff dinoboff commented Jan 4, 2017

targaryen cli now load rules using firebase-json which support comments and multi lines string.

Fix #30

@dinoboff
feat: use firebase-json to load rules
c52281e 
targaryen cli now load rules using firebase-json which support comments and multi lines string.

Fix goldibex#30
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.263% when pulling c52281e on dinoboff:feat-cli-json-parsing into 97f3de0 on goldibex:master.

@dinoboff dinoboff merged commit 227b9b9 into goldibex:master Jan 4, 2017
@dinoboff dinoboff deleted the feat-cli-json-parsing branch January 4, 2017 10:32
@dinoboff dinoboff modified the milestone: 3.0.0 Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dinoboff @coveralls