Use withDict to implement bindIP on recent GHCs
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to try and tackle |
Instead of `unsafeCoerce`, we can use the more recent `withDict` primitive from `GHC.Exts`. Among other benefits, this is more likely to be future-proof against possible changes to GHC's representation of "newtype classes" in the future. Fixes #165.
|
GHC#21575 is still not completely fixed as of GHC 9.4.1, so I think it's best to hold off on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
unsafeCoerce, we can use the more recentwithDictprimitive fromGHC.Exts. Among other benefits, this is more likely to be future-proof against possible changes to GHC's representation of "newtype classes" in the future.Fixes #165.