Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stereo call on a playing sound causes the onplay event to trigger #843

Closed
nicholashza opened this issue Oct 31, 2017 · 0 comments
Closed

First stereo call on a playing sound causes the onplay event to trigger #843

nicholashza opened this issue Oct 31, 2017 · 0 comments

Comments

@nicholashza
Copy link

The setupPanner function calls pause then resume if the sound is playing. Pause has a 'true' flag passed to prevent the pause event firing, but play does not. This creates a situation where playing a sound then setting it's stereo panning using stereo(x, internalId) causes a second play event callback. Is this intended behaviour?
bhaskarp-vg pushed a commit to ValueGlobal/howler.js that referenced this issue Feb 7, 2018
@goldfire @bhaskarp-vg
Prevent onplay from firing when first setting stereo value
77c8b96 
Fixes goldfire#843
ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
@goldfire
Prevent onplay from firing when first setting stereo value
65aceb5 
Fixes goldfire#843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholashza