Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound.fade() doesn't trigger onfade if from parameter is string #1027

Closed
CorySanin opened this issue Aug 25, 2018 · 1 comment
Closed

sound.fade() doesn't trigger onfade if from parameter is string #1027

CorySanin opened this issue Aug 25, 2018 · 1 comment

Comments

@CorySanin
Copy link

If the from parameter is the string representation of a number, _volume is set to NaN and onfade never gets triggered. Strangely, the fade still occurs (which is why it took me several hours to figure out what was actually causing the problem). It should either attempt to parse the string as a number, or it shouldn't perform the fade if the parameter isn't valid.
Another thing to consider is that when the to parameter is set to a string, it doesn't seem cause any issues.

@goldfire
Copy link
Owner

goldfire commented Sep 7, 2018

Thanks, should be fixed now with 8362b75.

ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants