-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link to Korean translation #671
Conversation
- Remove ^M chars
- Make it point to the Korean fork for the latest updates - Add songe to README Translations section
@songe Great progress! Why the right thing is linking to an external repo (fork) rather to an internal page? |
@goldbergyoni Since the fork will have the latest translations and changes before it gets merged in to master, I thought it'd be easier for the readers to have it point to the fork, at least while the Korean translation is still a work in progress. French & Spanish translations do the same thing and I thought I'd follow suit. I also thought this was what you were referring to in #665 (comment) |
@goldbergyoni Any updates on this? I plan on leaving the link only while the Korean translation is still a WIP. Once all the pages have been translated, I plan on revert it back to point to the main repo's README.korean.md |
@songe Sorry for the delay, we had a discussion whether translations should live on a fork. Our guideline is to strive having all the content here but it's OK to land a translation on a fork for <2 months and then it should get merged. Does this resonate with you? Kindly resolve conflict and I'll merge immediately. Sorry for keeping you waiting. |
Hello there! 👋 |
@goldbergyoni I just saw your comment. How can I reopen the PR so I can resolve conflicts to bring it back to a resolvable state? I can also remove the link to the fork during the rebase, since I guess I wasn't translating as actively as I thought I would. |
Reopen
--
Angie
…On Sat, Aug 22, 2020 at 11:49 AM stale[bot] ***@***.***> wrote:
Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90
days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#671 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALV5KPWM362J53NBI4LSRDSCAHJ7ANCNFSM4MN6LWHQ>
.
|
Make the link to Korean translation point to the fork rather than
README.korean.md
in the main repo, since the fork will contain the latest translations and changes.Also add translation additional translations for sections 1.4, 1.5, and 2.1.
Please review, @goldbergyoni @kevynb