Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to Korean translation #671

Closed
wants to merge 4 commits into from
Closed

Conversation

songe
Copy link
Contributor

@songe songe commented Apr 22, 2020

Make the link to Korean translation point to the fork rather than README.korean.md in the main repo, since the fork will contain the latest translations and changes.

Also add translation additional translations for sections 1.4, 1.5, and 2.1.

Please review, @goldbergyoni @kevynb

- Make it point to the Korean fork for the latest updates
- Add songe to README Translations section
@goldbergyoni
Copy link
Owner

@songe Great progress!

Why the right thing is linking to an external repo (fork) rather to an internal page?

@songe
Copy link
Contributor Author

songe commented Apr 25, 2020

@goldbergyoni Since the fork will have the latest translations and changes before it gets merged in to master, I thought it'd be easier for the readers to have it point to the fork, at least while the Korean translation is still a work in progress. French & Spanish translations do the same thing and I thought I'd follow suit.

I also thought this was what you were referring to in #665 (comment)

@songe
Copy link
Contributor Author

songe commented May 12, 2020

@goldbergyoni Any updates on this? I plan on leaving the link only while the Korean translation is still a WIP. Once all the pages have been translated, I plan on revert it back to point to the main repo's README.korean.md

@goldbergyoni
Copy link
Owner

@songe Sorry for the delay, we had a discussion whether translations should live on a fork. Our guideline is to strive having all the content here but it's OK to land a translation on a fork for <2 months and then it should get merged. Does this resonate with you?

Kindly resolve conflict and I'll merge immediately. Sorry for keeping you waiting.

@stale
Copy link

stale bot commented Aug 22, 2020

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Aug 22, 2020
@stale stale bot closed this Sep 2, 2020
@songe
Copy link
Contributor Author

songe commented Nov 15, 2020

@goldbergyoni I just saw your comment. How can I reopen the PR so I can resolve conflicts to bring it back to a resolvable state? I can also remove the link to the fork during the rebase, since I guess I wasn't translating as actively as I thought I would.

@songe
Copy link
Contributor Author

songe commented Nov 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants