Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'master' into korean-translation #668

Merged
merged 802 commits into from
Apr 21, 2020

Conversation

songe
Copy link
Contributor

@songe songe commented Apr 7, 2020

korean-translation branch is behind master. Meanwhile, newcomers will likely work off of branch korean-translation due to the Translations section pointing to this discussion (#94), but since the branch is outdated, they'll likely waste time re-translating the already translated section (which I've done myself).

Merge master into the branch to bring korean-translation branch up to date.

AbdelrahmanHafez and others added 30 commits January 10, 2020 06:35
The reason for file change is to correct the statement that the original author created to mean what was intended.
We are removing the double negative to improve clarity.
…s/add-germangamboa95

docs: add germangamboa95 as a contributor
Elaborate on 2.2 (Use only built-in Error object)
Added: Encryption of PII Data
updated
added PL flag
small fixes
updated
mbiesiad and others added 25 commits March 30, 2020 18:35
small fixes - new lines
little fix, improved
little fix, improved
small fix, improved
fixed, missing space key
fixed internal links
- Update intro & other sections to sound more natural in Korean
- Fix typos
- Add the missing code example in section 3.4
- Translate sections 6 & 7
- Remove 
 from breakintcomponents.korean.md
Translate the rest of README.korean.md
…s/add-songe

docs: add songe as a contributor
…s/add-mbiesiad

docs: add mbiesiad as a contributor
@songe
Copy link
Contributor Author

songe commented Apr 7, 2020

@goldbergyoni @kevynb Please review!

@kevynb
Copy link
Collaborator

kevynb commented Apr 21, 2020

Sorry @songe, I fell through that one!

@kevynb kevynb merged commit ef3be7d into goldbergyoni:korean-translation Apr 21, 2020
@songe songe deleted the korean-translation branch April 21, 2020 18:52
@songe songe restored the korean-translation branch April 21, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.