Update staticcheck and cache go/analysis facts #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't fork staticcheck: use the upstream version. Remove unneeded SSA loading.
jirfag
force-pushed
the
feature/update-staticcheck
branch
from
bb907a9 to
220ba2e
Compare
jirfag
changed the title
jirfag
force-pushed
the
feature/update-staticcheck
branch
2 times, most recently
from
6160ff2 to
a4d735f
Compare
Don't load unneeded packages for go/analysis. Repeated run of go/analysis linters now 10x faster (2s vs 20s on this repo) than before.
jirfag
force-pushed
the
feature/update-staticcheck
branch
from
a4d735f to
7edc530
Compare
This was referenced Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't load unneeded packages for go/analysis.
Repeated run of go/analysis linters now 10x faster
(2s vs 20s on this repo) than before.
Don't fork staticcheck: use the upstream version.
Remove unneeded SSA loading.