Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Go version propagation #5109

Merged
merged 19 commits into from
Nov 8, 2024
Merged

fix: Go version propagation #5109

merged 19 commits into from
Nov 8, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 6, 2024

  • isolates code related to cache
  • isolates the code borrowed from x/tools
  • updates the code borrowed from x/tools
  • fix Go version propagation

1 commit, 1 change.

I did some benchmarks and I didn't notice any performance improvements or regression after the update.

Fixes #4948
Related to #4907, #4905
Follows #5100

I will become an archaeologist with all this work on old code.
Next time, I will try to find the Lost Ark 😹

@ldez ldez added bug Something isn't working area: core labels Nov 6, 2024
@ldez ldez added this to the next milestone Nov 6, 2024
@ldez ldez requested a review from bombsimon November 6, 2024 16:02
@ldez ldez changed the title dev: fix Go version propagation fix; Go version propagation Nov 6, 2024
@ldez ldez changed the title fix; Go version propagation fix: Go version propagation Nov 6, 2024
pkg/goanalysis/runner_action_cache.go Outdated Show resolved Hide resolved
@ldez ldez merged commit 8c0c515 into golangci:master Nov 8, 2024
15 checks passed
@ldez ldez deleted the fix/core-cleaning branch November 8, 2024 01:01
@ldez ldez removed this from the next milestone Nov 10, 2024
@ldez ldez added this to the v1.62 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

staticcheck linter does not exclude checks for Go versions greater than specified in go.mod file
2 participants