fix: type sizing when cross-compiling (32-bit) #5053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint
should respectGOARCH
when performing typechecking.For example, the code below fails to build with
GOARCH=arm
, but succeeds withGOARCH=amd64
:golangci-lint
currently does not respectGOARCH
for typechecking because it does not settypes.Config.Sizes
, which tells the typecheck package how to determine the size of machine-specific types (like pointers anduintptr
). By default, iftypes.Config.Sizes
isnil
,SizesFor("gc", "amd64")
is used by default. This will notably break typechecking for 32-bit platforms.This PR sets
types.Config.Sizes
frombuild.Default
, which is set by theGOARCH
environment variable.