Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove GitHub Action problem matchers #4700

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: remove GitHub Action problem matchers #4700

merged 1 commit into from
May 7, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented May 6, 2024 •
edited
Loading

Restores the previous github-action format

#4695 (comment)

Fixes #4695

@ldez ldez added bug Something isn't working github_actions PR that update Github_actions code labels May 6, 2024
@ldez ldez added this to the next milestone May 6, 2024
@ldez ldez requested review from alexandear and bombsimon May 6, 2024 21:07
@ldez ldez marked this pull request as ready for review May 6, 2024 21:07
@ldez ldez mentioned this pull request May 6, 2024
Closed
bombsimon
bombsimon approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very important but why isn't this a revert?

@ldez
Copy link
Member Author

ldez commented May 6, 2024

I wrote several branches with different approaches and then I "restored" the previous version but I also renamed the structure and improved the doc.

@ldez ldez mentioned this pull request May 6, 2024
Closed
5 tasks
@ldez ldez merged commit 6767d7c into golangci:master May 7, 2024
13 checks passed
@ldez ldez deleted the fix/drop-problem-matchers branch May 7, 2024 00:26
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
@ldez ldez mentioned this pull request May 17, 2024
Merged
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
deps: update pre-commit hook golangci/golangci-lint to v1.58.1 (hetzn…
b403e97 
…ercloud/fleeting-plugin-hetzner!51)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [golangci/golangci-lint](https://github.com/golangci/golangci-lint) | repository | patch | `v1.58.0` -> `v1.58.1` |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>golangci/golangci-lint (golangci/golangci-lint)</summary>

### [`v1.58.1`](https://github.com/golangci/golangci-lint/releases/tag/v1.58.1)

[Compare Source](golangci/golangci-lint@v1.58.0...v1.58.1)

`golangci-lint` is a free and open-source project built by volunteers.

If you value it, consider supporting us, the [maintainers](https://github.com/golangci/golangci-lint?tab=readme-ov-file#contributors) and [linter authors](https://golangci-lint.run/product/thanks/).

We appreciate it! ❤️

For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#&#8203;1581).

#### Changelog

-   [`dc28153`](golangci/golangci-lint@dc281531) build(deps): bump github.com/4meepo/tagalign from 1.3.3 to 1.3.4 ([#&#8203;4705](golangci/golangci-lint#4705))
-   [`9116634`](golangci/golangci-lint@9116634a) build(deps): bump github.com/ghostiam/protogetter from 0.3.5 to 0.3.6 ([#&#8203;4707](golangci/golangci-lint#4707))
-   [`d64e1de`](golangci/golangci-lint@d64e1de7) build(deps): bump golang.org/x/tools from 0.20.0 to 0.21.0 ([#&#8203;4706](golangci/golangci-lint#4706))
-   [`ee97dbf`](golangci/golangci-lint@ee97dbf7) build(deps): bump golangci/golangci-lint-action from 5.1.0 to 5.3.0 ([#&#8203;4701](golangci/golangci-lint#4701))
-   [`4532eb9`](golangci/golangci-lint@4532eb98) fix: gochecknoinits shadow name ([#&#8203;4698](golangci/golangci-lint#4698))
-   [`6767d7c`](golangci/golangci-lint@6767d7c2) fix: remove GitHub Action problem matchers ([#&#8203;4700](golangci/golangci-lint#4700))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@alexandear alexandear Awaiting requested review from alexandear

Assignees
No one assigned
Labels
bug Something isn't working github_actions PR that update Github_actions code
Projects
None yet
Milestone
v1.58
Development

Successfully merging this pull request may close these issues.

Could not find file '/tmp/golangci-lint-action-problem-matchers.json'
2 participants
@ldez @bombsimon