feat: inactivate deprecated linters #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
the
linter: update
alexandear
reviewed
Mar 3, 2024
Antonboom
approved these changes
Mar 3, 2024
bombsimon
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
I like this!
There will always be people disappointed with changes like this but the list of linters has grown a lot and reducing it by removing deprecated linters seems very reasonable and shouldn't require any major release change or any other justification than the fact that they're deprecated.
Would it make sense to put a reason to this so we still get the warning message saying that it no longer will be run at all since it's removed and in a future version remove it completely?
😄 I didn't see your answer before I commenting here but we all share the same idea 👍 |
ldez
force-pushed
the
fix/noop-deprecated-linters
branch
from
800d7ca
to
f3d0213
Compare
ldez
changed the title
ldez
changed the title
nirs
added a commit
to nirs/cobra
that referenced
this pull request
May 18, 2024
Currently golangci-lint fails with these errors: ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] interfacer: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] maligned: This linter is fully inactivated: it will not produce any reports. I could not find any docs explaining what "fully inactivated" mean, but based this PR[1] it seems that these linters do nothing now. Removing the linters fixes this issue without changing linting, as they did not produce any report. Looking in the linters docs[2] I did not find a replacement for "interfacer" and "malinged" linters. "stylecheck" seems to be a replacement for "golint", but we need to fix the code to enable it. [1] golangci/golangci-lint#4436 [2] https://golangci-lint.run/usage/linters/
marckhouzam
pushed a commit
to spf13/cobra
that referenced
this pull request
May 19, 2024
* Remove fully inactivated linters Currently golangci-lint fails with these errors: ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] interfacer: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] maligned: This linter is fully inactivated: it will not produce any reports. I could not find any docs explaining what "fully inactivated" mean, but based this PR[1] it seems that these linters do nothing now. Removing the linters fixes this issue without changing linting, as they did not produce any report. Looking in the linters docs[2] I did not find a replacement for "interfacer" and "malinged" linters. "stylecheck" seems to be a replacement for "golint", but we need to fix the code to enable it. [1] golangci/golangci-lint#4436 [2] https://golangci-lint.run/usage/linters/ * Add stylecheck linter, replacement for golint This revealed 2 capitalized error messages. https://golangci-lint.run/usage/linters/#stylecheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently deprecated linters have been deprecated for a long time and a lot of then received their last commit in 2018-2019.
ifshortifshort: deprecate linter #3034 (2022)structcheck,varcheckfeat: deprecate varcheck, deadcode, and structcheck #3125 (2022)deadcodefeat: deprecate varcheck, deadcode, and structcheck #3125 (2022)golintDeprecate golint #1965 (2021)malignedDeprecate maligned, add govetfieldalignmentas replacement #1765 (2021)exhaustivestructfeat: addexhaustructlinter #2667 (2022)nosnakecasenosnakecase: deprecate linter #3065 (2022)interfacerDeprecateInterfacerlinter #1755 (2021)scopelintDeprecate 'scopelint' linter #1819 (2021)Some of them panic with go1.21 or go1.22. (ex: #4361)
I think it's time to remove them, but I don't want to be breaking.
I just replaced the real implementation with
Noop.The linters and their configuration can still be "used" inside the configuration (ex: inside
disable) and nothing will break.Each commit contains one change:
NoopNone of the changes are breaking.
With this PR all the deprecated dependencies, of those linters, are removed 🎉.
Related to #1987