Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misspell: add mode option #4275

Merged
merged 1 commit into from
Dec 22, 2023
Merged

misspell: add mode option #4275

merged 1 commit into from
Dec 22, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 20, 2023

Adds an option mode:

  • default: checks all the file content.
  • restricted: checks only comments.

This option is closed to the CLI flags source of misspell but I changed the naming and the value to have something less misleading.

@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Dec 20, 2023
@ldez ldez mentioned this pull request Dec 20, 2023
Closed
@ldez ldez requested a review from bombsimon December 22, 2023 00:12
@ldez ldez force-pushed the feat/misspell-mode branch from 582e5e3 to d1ec58e Compare December 22, 2023 00:15
@ldez ldez merged commit d99c02c into golangci:master Dec 22, 2023
12 checks passed
@ldez ldez deleted the feat/misspell-mode branch December 22, 2023 15:09
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez @Antonboom
misspell: add mode option (golangci#4275)
d581cb9
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.56
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @bombsimon