Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/catenacyber/perfsprint from 0.3.0 to 0.3.1 #4199

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps github.com/catenacyber/perfsprint from 0.3.0 to 0.3.1.

Commits
  • 9cd4cff feature: fmt.Sprintf with one argument optimization
  • 8c0a424 flag: option to disable errorf
  • bb9d531 style: code reorder
  • 29d8bb0 fix: make feature about err.Error() optional
  • 81b20c5 fix: have fix match gofmt
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/catenacyber/perfsprint](https://github.com/catenacyber/perfsprint) from 0.3.0 to 0.3.1.
- [Commits](catenacyber/perfsprint@v0.3.0...v0.3.1)

---
updated-dependencies:
- dependency-name: github.com/catenacyber/perfsprint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Nov 13, 2023
@ldez ldez added the linter: update version Update version of linter label Nov 13, 2023
@ldez
Copy link
Member

ldez commented Nov 13, 2023

The update is not a bugfix as the version increment (v0.3.1) suggested because it contains features and breaking changes.
It's important to follow semver.

It's the second time that this has happened:

@catenacyber please take care of that.

@ldez ldez merged commit be5c2e9 into master Nov 13, 2023
10 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/catenacyber/perfsprint-0.3.1 branch November 13, 2023 15:05
@catenacyber
Copy link
Contributor

Sorry @ldez indeed the last commit in 0.3.1 was a feature after some bugfixes like catenacyber/perfsprint#11

But I did not know v0.3.0 was already merged in golangcli-lint

@ldez
Copy link
Member

ldez commented Nov 13, 2023

But I did not know v0.3.0 was already merged in golangcli-lint

the problem is not related to golangci-lint but to your linter lifecycle: your linter is a standalone tool and a library, you should follow semver in all the cases, and your linter lifecycle should be independent of golangci-lint.

Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants