-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: add new source archive #3585
Conversation
Hey, thank you for opening your first Pull Request ! |
Hello, Can you explain how valuable this PR is to you or the other users? FYI, it's useless to ping Denis: he has not been active on the project for several years. |
I'm trying to add golangci-lint into the Wolfi OS; while working on this, I've noticed that there was no checksum entry for the source code tarball in the checksums.txt file, so, this PR is going to add it. |
This is not exactly what your PR is doing: currently we don't "build" a source code tarball, the tarball is provided by GitHub itself for a release it's not related to our release system. Your PR is adding the source code as a new tarball during the release, the checksum is just a consequence of this addition. So can you change the PR title and the PR description? |
yeah, it is going to add a new source archive as a tarball, I've updated it accordingly. Thank you. |
Signed-off-by: Batuhan Apaydın <[email protected]>
7721503
to
b3c875b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much for your assistance ☝️ really appreciate it 🫶 |
Co-authored-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Batuhan Apaydın [email protected]
PTAL @jirfag