-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate update for github-action-config.json #1208
Comments
So, actually we need to run these steps after a release. It means, that when the release workflow is completed, next one should run those steps, create a commit an push to the master branch |
Yes, you are right. Currently, I think we just wait till the issue with gorelease for brew gets resolved first, then the above steps can be done in the same job (after gorelease) |
This commit is to update metadata for golangci-lint-action after 1.32.0 release. NOTE: Once golangci#1208 is resolved, this step will be automated Relates golangci#1208 Signed-off-by: Tam Mach <[email protected]>
This commit is to update metadata for golangci-lint-action after 1.32.0 release. NOTE: Once #1208 is resolved, this step will be automated Relates #1208 Signed-off-by: Tam Mach <[email protected]>
This commit is to update metadata for golangci-lint-action after 1.32.1 release for couples of bug fixes. NOTE: Once golangci#1208 is resolved, this step will be automated Relates golangci#1208 Signed-off-by: Tam Mach [email protected] Signed-off-by: Tam Mach <[email protected]>
This commit is to update metadata for golangci-lint-action after 1.32.1 release for couples of bug fixes. NOTE: Once #1208 is resolved, this step will be automated Relates #1208 Signed-off-by: Tam Mach <[email protected]>
This commit is to update metadata for golangci-lint-action after 1.32.2 release for couples of bug fixes. NOTE: Once golangci#1208 is resolved, this step will be automated Relates golangci#1208 Signed-off-by: Tam Mach <[email protected]>
This commit is to update metadata for golangci-lint-action after 1.32.2 release for couples of bug fixes. NOTE: Once #1208 is resolved, this step will be automated Relates #1208 Signed-off-by: Tam Mach <[email protected]>
@sayboras I feel to commit changes automatically we need a user account/bot. Question: Have |
AFAIK changes can be commited via default github actions user, but I can be wrong |
@denis-tingajkin @ernado I also think github action user can do so, similar to goreleaser is able to create the release. Might need to test it out. I did have dependabot commit directly into master in my repo before. |
@sayboras it's easy, except on part. The master branch is protected, we need to create the Pull Request from an action.
|
I know that the default GITHUB_TOKEN does not allow creation of the pull requests, but we can use |
or if the |
Need to investigate on how to automate this
Originally posted by @sayboras in #1207 (comment)
Currently we have Make target
make assets/github-action-config.json
to update github-action-config.json, will be better to have it run as part of release automatically.Updated: Just found the below steps in https://github.com/golangci/golangci-lint/blob/master/docs/src/docs/contributing/workflow.mdx
After making a release you need to update (TODO: automate partially):
make update_contributors_list # may take 15 min
`
The text was updated successfully, but these errors were encountered: