dev: reused exit codes (#2364)

golangci · Nov 18, 2021 · ef92894 · ef92894
1 parent 9cdc7af
commit ef92894
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/pkg/commands/cache.go b/pkg/commands/cache.go
@@ -8,6 +8,7 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/golangci/golangci-lint/internal/cache"
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
@@ -51,7 +52,7 @@ func (e *Executor) executeCleanCache(_ *cobra.Command, args []string) {
 		e.log.Fatalf("Failed to remove dir %s: %s", cacheDir, err)
 	}
 
-	os.Exit(0)
+	os.Exit(exitcodes.Success)
 }
 
 func (e *Executor) executeCacheStatus(_ *cobra.Command, args []string) {
@@ -66,7 +67,7 @@ func (e *Executor) executeCacheStatus(_ *cobra.Command, args []string) {
 		fmt.Fprintf(logutils.StdOut, "Size: %s\n", fsutils.PrettifyBytesCount(cacheSizeBytes))
 	}
 
-	os.Exit(0)
+	os.Exit(exitcodes.Success)
 }
 
 func dirSizeBytes(path string) (int64, error) {

diff --git a/pkg/commands/config.go b/pkg/commands/config.go
@@ -64,5 +64,5 @@ func (e *Executor) executePathCmd(_ *cobra.Command, args []string) {
 	}
 
 	fmt.Println(usedConfigFile)
-	os.Exit(0)
+	os.Exit(exitcodes.Success)
 }
diff --git a/pkg/commands/help.go b/pkg/commands/help.go
@@ -9,6 +9,7 @@ import (
 	"github.com/fatih/color"
 	"github.com/spf13/cobra"
 
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
@@ -93,5 +94,5 @@ func (e *Executor) executeLintersHelp(_ *cobra.Command, args []string) {
 		fmt.Fprintf(logutils.StdOut, "%s: %s\n", color.YellowString(p), strings.Join(linterNames, ", "))
 	}
 
-	os.Exit(0)
+	os.Exit(exitcodes.Success)
 }
diff --git a/pkg/commands/linters.go b/pkg/commands/linters.go
@@ -7,6 +7,7 @@ import (
 	"github.com/fatih/color"
 	"github.com/spf13/cobra"
 
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 )
 
@@ -48,5 +49,5 @@ func (e *Executor) executeLinters(_ *cobra.Command, args []string) {
 	color.Red("\nDisabled by your configuration linters:\n")
 	printLinterConfigs(disabledLCs)
 
-	os.Exit(0)
+	os.Exit(exitcodes.Success)
 }
diff --git a/pkg/commands/root.go b/pkg/commands/root.go
@@ -12,13 +12,14 @@ import (
 	"github.com/spf13/pflag"
 
 	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
 
 func (e *Executor) persistentPreRun(_ *cobra.Command, _ []string) {
 	if e.cfg.Run.PrintVersion {
 		fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date)
-		os.Exit(0)
+		os.Exit(exitcodes.Success)
 	}
 
 	runtime.GOMAXPROCS(e.cfg.Run.Concurrency)

diff --git a/pkg/config/reader.go b/pkg/config/reader.go
@@ -10,6 +10,7 @@ import (
 	"github.com/mitchellh/go-homedir"
 	"github.com/spf13/viper"
 
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/sliceutil"
@@ -87,7 +88,7 @@ func (r *FileReader) parseConfig() error {
 
 	if r.cfg.InternalTest { // just for testing purposes: to detect config file usage
 		fmt.Fprintln(logutils.StdOut, "test")
-		os.Exit(0)
+		os.Exit(exitcodes.Success)
 	}
 
 	return nil