Skip to content

Commit

Permalink
Fix nil pointer in codeclimate.go (#1077)
Browse files Browse the repository at this point in the history
Some issues don't have any source lines
  • Loading branch information
☃ Elliot Shepherd authored May 11, 2020
1 parent 206d79f commit c88df8f
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pkg/printers/codeclimate.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,14 @@ func (p CodeClimate) Print(ctx context.Context, issues []result.Issue) error {
issue.Location.Path = i.Pos.Filename
issue.Location.Lines.Begin = i.Pos.Line

// Need a checksum of the issue, so we use MD5 of the filename, text, and first line of source
// Need a checksum of the issue, so we use MD5 of the filename, text, and first line of source if there is any
var firstLine string
if len(i.SourceLines) > 0 {
firstLine = i.SourceLines[0]
}

hash := md5.New() //nolint:gosec
_, _ = hash.Write([]byte(i.Pos.Filename + i.Text + i.SourceLines[0]))
_, _ = hash.Write([]byte(i.Pos.Filename + i.Text + firstLine))
issue.Fingerprint = fmt.Sprintf("%X", hash.Sum(nil))

allIssues = append(allIssues, issue)
Expand Down

0 comments on commit c88df8f

Please sign in to comment.