Fix misleading version input description #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tam Mach <[email protected]>
iwankgb
reviewed
Jul 5, 2020
I think golangci-lint will refer to https://github.com/golangci/golangci-lint/blob/master/assets/github-action-config.json for the exact version to install. The reason I didn't update to v1.28 to avoid chicken and egg issue, as golangci-lint uses golangci-lint-action and via versa. Moreover, this PR got recreated before golangci/golangci-lint#1207 is merged. |
|
1.28.0 seems to be available now in all necessary places so I think it's safe to upgrade version in this PR too. |
iwankgb
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Signed-off-by: Tam Mach [email protected]