Extract and don't mangle User Args. #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation mangles the contents of
userArgsNames
and prevents the successful checks that follow (preventing settingout-format
and any of thenew-
parameters. This fix extracts the names with a regex without mangling them. The original iterative extraction looked creative and mildly elegant, but in testing, expanding it to not mangle the names made it less elegant, so using aregex
and doing it in one go without iterating the array seemed like a simpler and more straight-forward approach.Resolves: #199
Note: It looks like this bug has been in here for about 10 months (10cbc92), fixing this may break existing deployments. Especially considering how I just suggested using this bug as a use-case fix.