Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: add bytedance golang solution #287

Closed
wants to merge 1 commit into from

Conversation

GuangmingLuo
Copy link
Contributor

@GuangmingLuo GuangmingLuo commented Jun 14, 2024

Go was introduced to ByteDance in 2014, and since then engineering teams across ByteDance have adopted Go to build products and services on a massive scale.

@gopherbot
Copy link
Contributor

This PR (HEAD: b6e24d5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/592715.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from guangming Luo:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@GuangmingLuo
Copy link
Contributor Author

@rsc hello, please help to review this, thanks

@GuangmingLuo
Copy link
Contributor Author

@cameronbalahan hi, any progress ?

@GuangmingLuo
Copy link
Contributor Author

hello, is there anyone in charge of this repo ?

@cameronbalahan
Copy link
Contributor

Hi Guangmin, I will review this in the next two weeks. Apologies for not looking sooner; I'm out of office.

@GuangmingLuo
Copy link
Contributor Author

@cameronbalahan hello, any progress ? One and a half month already :)

@gopherbot
Copy link
Contributor

Message from Cameron Balahan:

Patch Set 2: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-08-12T23:27:05Z","revision":"e363e9d9c208b82e1445dafd96e518e34b764fcc"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/592715.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 15, 2024
Go was introduced to ByteDance in 2014, and since then engineering teams across ByteDance have adopted Go to build products and services on a massive scale.

Change-Id: I1554da05c15c3cc1f4a07414bb488764c8e2e3dd
GitHub-Last-Rev: b6e24d5
GitHub-Pull-Request: #287
Reviewed-on: https://go-review.googlesource.com/c/website/+/592715
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Cameron Balahan <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/592715 has been merged.

@gopherbot gopherbot closed this Aug 15, 2024
@GuangmingLuo GuangmingLuo deleted the bytedance branch August 16, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants