New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: removes unused helper function isCVE #1116

Closed

vrnvu wants to merge 1 commit into golang:master from vrnvu:removes-helper

Contributor

vrnvu commented Nov 20, 2022

I guess this was attempted to be used here: https://github.com/vrnvu/vulndb/blob/b776e182e6934a1e7bcab96f018f1b26ee3f3f52/internal/ghsa/ghsa.go#L206


          internal: removes unused helper function isCVE

b776e18

Contributor

gopherbot commented Nov 20, 2022

This PR (HEAD: b776e18) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vulndb/+/452295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Nov 20, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Tatiana Bradley:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Tatiana Bradley:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Cherry Mui:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2022

Message from Damien Neil:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/452295.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          internal: removes unused helper function isCVE

b484d03

I guess this was attempted to be used here: https://github.com/vrnvu/vulndb/blob/b776e182e6934a1e7bcab96f018f1b26ee3f3f52/internal/ghsa/ghsa.go#L206

Change-Id: Ie9fd51079210dbb653c483b48c0dd27ac2f12165
GitHub-Last-Rev: b776e18
GitHub-Pull-Request: #1116
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/452295
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Tatiana Bradley <[email protected]>
Run-TryBot: Tatiana Bradley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Contributor

gopherbot commented Nov 22, 2022

This PR is being closed because golang.org/cl/452295 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet