package.json: change gopath/goroot/toolsGopath machine-overridable #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting them machine-overridable, client user values can be ignored in remote settings and the remote side can pick up the right value. I think go.alternateTools should be machine-overridable as well but will get to it next time. Manually tested by 1) setting go.gopath in user settings, vsce package, connecting to the remote host, sideloading vsix (do it after connecting, so the remote host can pick up the vsix), and checking the GOPATH with "Go: Current GOPATH" and also, by reinstalling all tools. 2) setting go.gopath in workspace settings and checking it's still doable. Fixes microsoft#2981 Updates microsoft#2576 Change-Id: I3390355d186280c13353d210adb51edfa3858032
googlebot
added
the
cla: yes
|
This PR (HEAD: 0463b84) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/236539 to see it. Tip: You can toggle comments from me using the |
|
Message from Rebecca Stambler: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/236539. |
gopherbot
pushed a commit
that referenced
this pull request
Jun 4, 2020
By setting them machine-overridable, client user values can be ignored in remote settings and the remote side can pick up the right value. I think go.alternateTools should be machine-overridable as well but will get to it next time. Manually tested by 1) setting go.gopath in user settings, vsce package, connecting to the remote host, sideloading vsix (do it after connecting, so the remote host can pick up the vsix), and checking the GOPATH with "Go: Current GOPATH" and also, by reinstalling all tools. 2) setting go.gopath in workspace settings and checking it's still doable. Fixes microsoft/vscode-go#2981 Updates microsoft/vscode-go#2576 Change-Id: I3390355d186280c13353d210adb51edfa3858032 Change-Id: I3390355d186280c13353d210adb51edfa3858032 GitHub-Last-Rev: 0463b84 GitHub-Pull-Request: #175 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236539 Reviewed-by: Rebecca Stambler <[email protected]>
|
This PR is being closed because golang.org/cl/236539 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting them machine-overridable, client user values can be
ignored in remote settings and the remote side can pick up the right
value.
I think go.alternateTools should be machine-overridable as well
but will get to it next time.
Manually tested by
setting go.gopath in user settings, vsce package,
connecting to the remote host, sideloading vsix (do it after connecting,
so the remote host can pick up the vsix), and checking the GOPATH
with "Go: Current GOPATH" and also, by reinstalling all tools.
setting go.gopath in workspace settings and checking it's still doable.
Fixes microsoft/vscode-go#2981
Updates microsoft/vscode-go#2576
Change-Id: I3390355d186280c13353d210adb51edfa3858032