Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

third_party/tree-kill: always use the default pgrep on mac #174

Closed
wants to merge 1 commit into from
Closed

third_party/tree-kill: always use the default pgrep on mac #174

wants to merge 1 commit into from

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Jun 4, 2020

The proctools' pgrep is problematic when running with -P.

Fixes #90

Change-Id: If3e306cd725a7c88873ca40d74c1581e2d695ea4

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 4, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 4985778ecbecc0bc507e9797803034dbc6a50012) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/236538 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/236538.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/236538.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 7b2270c5392c93ce190c1d3db74b95d89c321c8b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/236538 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hyangah
third_party/tree-kill: always use the default pgrep on mac
2933f71 
The proctools' pgrep is problematic when running with -P.

Fixes golang/vscode-go#90

Change-Id: If3e306cd725a7c88873ca40d74c1581e2d695ea4
@gopherbot
Copy link
Collaborator

This PR (HEAD: 2933f71) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/236538 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Jun 17, 2020
@hyangah
third_party/tree-kill: always use the default pgrep on mac
bf28864 
The proctools' pgrep is problematic when running with -P.

Fixes #90

Change-Id: If3e306cd725a7c88873ca40d74c1581e2d695ea4

Change-Id: If3e306cd725a7c88873ca40d74c1581e2d695ea4
GitHub-Last-Rev: 2933f71
GitHub-Pull-Request: #174
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236538
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/236538 has been merged.

@gopherbot gopherbot closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tree-kill: spawns too many pgrep processes, causing the extension to become unresponsive
3 participants
@hyangah @gopherbot @googlebot