-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/goTestExplorer: implement a test provider for the new test api #1590
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: ccb25a9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
ccb25a9
to
6cf3c3d
Compare
This PR (HEAD: 6cf3c3d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 73f15b3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Suzy Mueller: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from Ethan Reesor: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
This PR (HEAD: ef064dc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Suzy Mueller: Patch Set 8: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from kokoro: Patch Set 8: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from kokoro: Patch Set 8: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
This PR (HEAD: 1ee5851) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Suzy Mueller: Patch Set 9: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from kokoro: Patch Set 9: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from kokoro: Patch Set 9: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from Ethan Reesor: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
Message from Suzy Mueller: Patch Set 9: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
f005945
to
77f3623
Compare
This PR (HEAD: 77f3623) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Ethan Reesor: Patch Set 10: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
This PR (HEAD: 24faa6b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Ethan Reesor: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
This PR (HEAD: ee4a140) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Message from Ethan Reesor: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/330809. |
This PR (HEAD: 305f2c3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it. Tip: You can toggle comments from me using the |
Change function names and add comments.
Fix a dumb mistake and remove a TODO.
7d8ab99
to
a9a5551
Compare
a9a5551
to
5e41e65
Compare
What this does: - Implements a test provider using the new API - Populates the test explorer with a list of modules and/or workspaces - Populates each module/workspace/package/file as it is expanded - Creates test entries for the current file, and package/module parents - Runs tests! What this does not: - Debug tests - Handle stretchr suites Issues: - Handling of benchmarks isn't great. But I'm not sure it can get much better without changes to `go test`. - If a test has subtests, I add those subtests. This can get annoying if you have a bunch of subtests. Should this be configurable? Disabling `testing.followRunningTest` can improve this UX. Fixes #1579 Change-Id: I027c7c3b615eda4c528da9739520e6bfd1aa6911 GitHub-Last-Rev: 59af29b GitHub-Pull-Request: #1590 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/330809 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Suzy Mueller <[email protected]>
What this does:
What this does not:
Issues:
better without changes to
go test
.you have a bunch of subtests. Should this be configurable? Disabling
testing.followRunningTest
can improve this UX.Fixes #1579