Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/debugAdapter: disable stackTrace error pop-ups #1236

Closed
wants to merge 3 commits into from
Closed

src/debugAdapter: disable stackTrace error pop-ups #1236

wants to merge 3 commits into from

Conversation

polinasok
Copy link
Contributor

@polinasok polinasok commented Feb 18, 2021 •
edited by hyangah
Loading

The errors already show up in the UI under CALL STACK, so the pop-ups just get in the way.

Updates #179

@polinasok polinasok requested a review from hyangah February 18, 2021 10:02
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 18, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: 3bf6d6d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/293530 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: b860a18) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/293530 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/293530.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/8cdc2ae6-8e65-4628-9cd8-60c16411091d

Please don’t reply on this GitHub thread. Visit golang.org/cl/293530.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 3: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/8cdc2ae6-8e65-4628-9cd8-60c16411091d

Please don’t reply on this GitHub thread. Visit golang.org/cl/293530.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/293530.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/293530.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: b3a2611) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/293530 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Feb 23, 2021
@polinasok
src/debugAdapter: disable stackTrace error pop-ups
54602c5 
The errors already show up in the UI under CALL STACK, so the pop-ups just get in the way.

Updates #179

Change-Id: I3ba1e7c65c363e00d16b0962a83b0f873bfd0e60
GitHub-Last-Rev: b3a2611
GitHub-Pull-Request: #1236
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/293530
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Trust: Polina Sokolova <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/293530 has been merged.

@gopherbot gopherbot closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyangah hyangah Awaiting requested review from hyangah

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polinasok @gopherbot