Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: update to the latest version when we turn it on by default #938

Closed
stamblerre opened this issue Nov 19, 2020 · 4 comments
Closed

gopls: update to the latest version when we turn it on by default #938

stamblerre opened this issue Nov 19, 2020 · 4 comments
Assignees
@suzmue
Labels
FrozenDueToAge
Milestone
v0.20.0

Comments

@stamblerre
Copy link
Contributor

Users who have opted out of gopls may have outdated versions on their machines. We should not delay before prompting them to update--we should update right away, before we turn it on.
@hyangah hyangah added this to the v0.20.0 milestone Nov 20, 2020
@hyangah
Copy link
Contributor

hyangah commented Nov 20, 2020

This is critical for the first user experience.

@suzmue suzmue self-assigned this Nov 20, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/274250 mentions this issue: src/goLanguageServer.ts: update gopls when gopls is turned on by default

gopherbot pushed a commit that referenced this issue Dec 11, 2020
@suzmue
src/goLanguageServer.ts: update gopls when gopls is turned on by default
211c7a6 
When the gopls configuration turns on by default, the user may already
have an old gopls binary installed. If this is the case we want to be sure
to update it before enabling the language server.

Updates #938

Change-Id: I06a738b7a3bc5e06191269178ac3a2775d93eb16
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/274250
Trust: Suzy Mueller <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@hyangah hyangah modified the milestones: v0.21.0, v0.20.0 Dec 14, 2020
@stamblerre
Copy link
Contributor Author

Can we close this now that https://golang.org/cl/274250/ is merged, or is there other work to do here?

@hyangah
Copy link
Contributor

hyangah commented Dec 16, 2020

Thanks @suzmue !

@hyangah hyangah closed this as completed Dec 16, 2020
@golang golang locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @suzmue @gopherbot