test: make sure user's configuration or environment does not affect tests #43
Comments
|
That's one of the motivation I had when adding the docker-based setup Another approach is to utilize (reference: https://vscode-dev-community.slack.com/archives/C74CB59NE/p1585956905048000) |
|
Seems like the |
installation tests require multiple fs operations, and 2s may be too short to complete everything on time. Allow more time. And disable the gopls update check in gopls testing. That shortens the time to bring up the gopls server. Also remove the hack to start the test with a clean user profile (--user-data-dir). That doesn't seem to work but interferes with picking up the workspace settings, which I do not understand why. Updates golang/vscode-go#169 Updates golang/vscode-go#43 Updates microsoft/vscode#97995 Change-Id: I5dbb33514a25a2071bf5bdf4ad248087e7e9b322
|
Change https://golang.org/cl/238001 mentions this issue: |
installation tests require multiple fs operations, and 2s may be too short to complete everything on time. Allow more time. And disable the gopls update check in gopls testing. That shortens the time to bring up the gopls server. Also remove the hack to start the test with a clean user profile (--user-data-dir). That doesn't seem to work but interferes with picking up the workspace settings, which I do not understand why. Updates #169 Updates #43 Updates microsoft/vscode#97995 Change-Id: I0e8b7d8f1f47f2e68696c6bd078c1ad2a0fe6780 GitHub-Last-Rev: f414011 GitHub-Pull-Request: #231 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238001 Reviewed-by: Rebecca Stambler <[email protected]>
…fects The delveConfig user settings applied in settings.json, should be applied to the debug configuration. Test that these are correctly applied. Additionally, testFlags and buildFlags do not currently affect the debug configuration, so we also test that to document that behavior. This behavior is likely to change and the test should be updated when it does. This change also reintroduces the --user-data-dir= argument to the launch configuration for running the integration tests. This starts the test with the default user settings, so running the tests should not be affected by the user settings. Update #43 Change-Id: I99c9d7f17892e6766fae731c9288880b109ba3fd Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/267217 Trust: Suzy Mueller <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
|
Change https://golang.org/cl/267217 mentions this issue: |
|
The adjustment made by https://go-review.googlesource.com/c/vscode-go/+/267217 fixed this issue. Thanks @suzmue ! |
Some tests in the extension fail when the user running them has unexpected configurations or when they don't have the correct tools installed. We should make sure all test runs are independent of the user's environment.
microsoft/vscode-go#801 describes a specific fix that should be applied to one of the tests.
The text was updated successfully, but these errors were encountered: