Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: automate latest version string update for gopls, dlv-dap as part of release process #1403

Open
hyangah opened this issue Apr 7, 2021 · 1 comment
Open

release: automate latest version string update for gopls, dlv-dap as part of release process #1403

hyangah opened this issue Apr 7, 2021 · 1 comment
Milestone
vscode-go/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 7, 2021

Consider to update these version info fields automatically as part of the extension release process.

gopls

vscode-go/src/goTools.ts

Lines 430 to 434 in 66b684a

minimumGoVersion: semver.coerce('1.12'),
latestVersion: semver.coerce('0.6.8'),
latestVersionTimestamp: moment('2021-03-17', 'YYYY-MM-DD'),
latestPrereleaseVersion: semver.coerce('0.6.8'),
latestPrereleaseVersionTimestamp: moment('2021-03-17', 'YYYY-MM-DD')

dlv dap

vscode-go/src/goTools.ts

Lines 453 to 454 in 66b684a

latestVersion: semver.parse('v1.6.1-0.20210402163444-c223ef656da3'),
latestVersionTimestamp: moment('2021-04-02', 'YYYY-MM-DD')

For gopls, we may consider updating them as soon as the new version of gopls is released because we use only tagged versions. For dlv-dap, we live with dev version built from the master, so extension release time may be a good time (we will still manually update the dlv-dap version when significant features landed in delve and want to push to the Nightly users soon).

@suzmue @stamblerre @polinasok
@hyangah hyangah mentioned this issue Apr 7, 2021
Closed
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre modified the milestones: Untriaged, On Deck Apr 9, 2021
@hyangah hyangah modified the milestones: On Deck, Backlog Apr 16, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/319029 mentions this issue: tools/generate.go: update gopls and dlv-dap versions in generate

gopherbot pushed a commit that referenced this issue May 17, 2021
@suzmue
tools/generate.go: update gopls and dlv-dap versions in generate
0f4b38f 
Both gopls and dlv-dap have frequent updates, so we frequently need
to change the latest versions to keep our users up to date.

This updates the generate script to also update the versions in
src/goTools.ts.

Updates #1403

Change-Id: Ic6de1ce8cbe9c97d89f48c4b689271d75be5bb17
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/319029
Trust: Suzy Mueller <[email protected]>
Run-TryBot: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot