src/goEnv: unset GOOS/GOARCH/GOROOT/... from tool installation env

Tool installation is to build tools that would run in the host machine. Applying GOOS/GOARCH/GOROOT/GOFLAGS/GOENV set to build a cross-platform project is not the right choice. Unset them and let the `go` command figure out. There could be other environment variables that would affect build (GCCGO, ..), and we will consider unsetting them. Update #628 Change-Id: I295a0ae455aa2624550a16f69686bdf191fe41fd Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/264323 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Suzy Mueller <[email protected]>
golang · Nov 19, 2020 · bf1225f · bf1225f
1 parent d7563f6
commit bf1225f
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/goEnv.ts b/src/goEnv.ts
@@ -39,6 +39,15 @@ export function toolInstallationEnvironment(): NodeJS.Dict<string> {
 	}
 	env['GOPATH'] = toolsGopath;
 
+	// Unset env vars that would affect tool build process: 'GOROOT', 'GOOS', 'GOARCH', ...
+	// Tool installation should be done for the host OS/ARCH (GOHOSTOS/GOHOSTARCH) with
+	// the default setup.
+	delete env['GOOS'];
+	delete env['GOARCH'];
+	delete env['GOROOT'];
+	delete env['GOFLAGS'];
+	delete env['GOENV'];
+
 	return env;
 }