Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src/goLanguageServer: disable language service on guest side completely
The language client library sends workspace folder with vsls uri scheme which makes gopls unhappy. According to LiveShare guideline https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/extensions#visual-studio-code-1 "Guests receive the language service results from both their local extensions, and the host, and therefore, if both participants have the same language service extension installed, guests will see duplicate entries for certain things (e.g. auto-completion, code actions)" That implies the language service on the guest side is unnecessary. Actually, excluding all the go files, there is no reason to start the language server at all. Manually tested. Fixes #605 Fixes #1024 Change-Id: Ib9e72fe848a202c9e3cc9aa4d183a2919cf07797 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/277392 Reviewed-by: Rebecca Stambler <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]>
- Loading branch information