Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize insert method in Sparse by inlining wordMask logic #535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

myeunee
Copy link
Contributor

@myeunee myeunee commented Oct 15, 2024

Optimized the insert method in the Sparse type by inlining the logic of the
wordMask function directly within the method. This change eliminates the
overhead of an additional function call, resulting in a slight performance
improvement during insert operations.

While the core logic remains unchanged, this optimization could provide minor
gains in performance, particularly in tight loops or performance-sensitive
scenarios where the insert method is frequently called.

The change has been localized to container/intsets/sparse.go.

@gopherbot
Copy link
Contributor

This PR (HEAD: bf52a4c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/620416.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620416.
After addressing review feedback, remember to publish your drafts!

@myeunee myeunee changed the title fix: optimize wordMask usage in insert method perf: optimize insert method in Sparse by inlining wordMask logic Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants