gopls/internal/lsp/cache: don't trace a region for MetadataForFile

In the common case, MetadataForFile is just a map lookup. Benchmarks demonstrate that capturing a trace region is too expensive. Change-Id: I02d2b65de88f5db37beb16fba034e3c49c5f6096 Reviewed-on: https://go-review.googlesource.com/c/tools/+/481785 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Alan Donovan <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]>
golang · Apr 4, 2023 · d5076cc · d5076cc
1 parent f796361
commit d5076cc
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/gopls/internal/lsp/cache/snapshot.go b/gopls/internal/lsp/cache/snapshot.go
@@ -740,9 +740,6 @@ func (s *snapshot) MethodSets(ctx context.Context, ids ...PackageID) ([]*methods
 }
 
 func (s *snapshot) MetadataForFile(ctx context.Context, uri span.URI) ([]*source.Metadata, error) {
-	ctx, done := event.Start(ctx, "cache.snapshot.MetadataForFile")
-	defer done()
-
 	s.mu.Lock()
 
 	// Start with the set of package associations derived from the last load.